Opened 5 years ago

Closed 5 years ago

#2187 closed change (fixed)

Drop class rietveld::private in favor of function hiera()

Reported by: matze Assignee: matze
Priority: P4 Milestone:
Module: Infrastructure Keywords:
Cc: fhd Blocked By: #2185
Blocking: #2182 Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/6703666383814656/

Description

With the integration of Hiera (#112), class rietveld::private can be replaced by hiera() function calls within class rietveld, which isa way cleaner approach..

Change History (5)

comment:1 Changed 5 years ago by matze

  • Blocked By 2185 added

Ticket #2185 will render $rietveld::private::admin_password obsolete.

comment:2 Changed 5 years ago by matze

  • Cc fhd added
  • Review URL(s) modified (diff)

comment:3 Changed 5 years ago by matze

  • Review URL(s) modified (diff)

comment:4 Changed 5 years ago by matze

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 5 years ago by matze

  • Resolution set to fixed
  • Status changed from reviewing to closed
  • Verified working unset
Note: See TracTickets for help on using tickets.