Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#2193 closed change (fixed)

Add notification opt-out to Firefox

Reported by: greiner Assignee: greiner
Priority: P2 Milestone: Adblock-Plus-2.6.10-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: saroyanm, sven Blocked By: #2192
Blocking: #2191, #2726 Platform: Firefox
Ready: yes Confidential: no
Tester: Ross Verified working: no
Review URL(s):

http://codereview.adblockplus.org/6526453483044864/

Description (last modified by trev)

Background

In #2192 we added opt-out capabilities for notifications and we need to expose those in the extension UI.

What to change

Notification:

  • Add an "x" in the top-right corner of the notification.
  • Upon clicking the "x", the notification content should be replaced with the following two links (see screenshot):
    • Close this notification: Hide the notification
    • Stop showing notifications: Hide the notification and add "*" to Prefs.notifications_ignoredcategories

The following options should be hidden by default and only be shown if Prefs.notifications_showui is set to true:

Options menu:

  • Add a menu item "Show useful notifications" to icon context menu's "Options" submenu. Note that this menu is also used within the browser menu bar (see screenshot).
  • Clicking on this item should toggle the "*" entry in Prefs.notifications_ignoredcategories.

Preferences page:

  • Add a checkbox "Show useful notifications" to preferences page at "about:addons".
  • This checkbox should toggle the "*" entry in Prefs.notifications_ignoredcategories.

Attachments (2)

notification-menu_firefox.png (24.1 KB) - added by greiner 5 years ago.
notification-panel_firefox.png (9.6 KB) - added by greiner 5 years ago.

Download all attachments as: .zip

Change History (13)

Changed 5 years ago by greiner

Changed 5 years ago by greiner

comment:1 Changed 5 years ago by greiner

  • Description modified (diff)

comment:2 Changed 5 years ago by greiner

  • Blocked By 2192 added
  • Description modified (diff)

comment:3 Changed 5 years ago by saroyanm

  • Cc saroyanm added
  • Verified working unset

comment:4 Changed 5 years ago by greiner

  • Owner set to greiner
  • Summary changed from Add UI for opting-out of notifications to Firefox to Add notification opt-out to Firefox

comment:5 Changed 5 years ago by greiner

  • Cc sven added
  • Description modified (diff)

Updated texts to make them shorter and more accurate following a discussion with Sven.

comment:6 Changed 5 years ago by greiner

  • Description modified (diff)

comment:7 Changed 5 years ago by trev

  • Description modified (diff)
  • Ready set

comment:8 Changed 5 years ago by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:9 Changed 4 years ago by greiner

  • Blocking 2726 added

comment:10 Changed 4 years ago by greiner

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:11 Changed 4 years ago by Ross

  • Platform changed from Unknown to Firefox
  • Tester set to Ross

Add an "x" in the top-right corner of the notification.

Done / Working.

Upon clicking the "x", the notification content should be replaced with the following two links (see screenshot​):

Close this notification: Hide the notification
Stop showing notifications: Hide the notification and add "*" to Prefs.notifications_ignoredcategories

Done / Working.

The following options should be hidden by default and only be shown if Prefs.notifications_showui is set to true

Done / Working.

Add a menu item "Show useful notifications" to icon context menu's "Options" submenu. Clicking on this item should toggle the "*" entry in Prefs.notifications_ignoredcategories.

Done / Working.

Add a checkbox "Show useful notifications" to preferences page at "about:addons". This checkbox should toggle the "*" entry in Prefs.notifications_ignoredcategories.

Done / Working.

Tested with:
ABP 2.6.9.3966 / Firefox 39.0 / Windows 7 x64

(Note: I attempted to test on OS X, however Firefox in OS X in a VM is currently affected by this bug (https://bugzilla.mozilla.org/show_bug.cgi?id=1180688) and nightlies are e10s, which also does not work in VM for me at the moment.)

Note: See TracTickets for help on using tickets.