Opened 5 years ago

Closed 5 years ago

#2196 closed change (fixed)

[cms] Drop depencency on Flask for test server

Reported by: trev Assignee: trev
Priority: P4 Milestone:
Module: Sitescripts Keywords:
Cc: Blocked By:
Blocking: #2197 Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working:
Review URL(s):

http://codereview.adblockplus.org/6451712864813056/

Description

Background

We currently require Flask to run our test server. However, the CMS web app is very simple, the Flask framework is an overkill.

What to change

Use the werkzeug.simple module directly instead of calling it via Flask. If Werkzeug isn't installed, fall back to the wsgiref module that is built into Python - compared to Werkzeug this one merely lacks developer features.

Change History (3)

comment:1 Changed 5 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 5 years ago by trev

  • Blocking 2197 added

comment:3 Changed 5 years ago by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.