Opened 4 years ago

Closed 4 years ago

#2207 closed defect (duplicate)

Add filter dialog does not appear and contains incorrect filter

Reported by: passbrains Assignee:
Priority: Unknown Milestone:
Module: Platform Keywords:
Cc: sebastian, mapx Blocked By:
Blocking: Platform: Chrome
Ready: no Confidential: no
Tester: Verified working: no
Review URL(s):

Description (last modified by Ross)

Adapted from https://www.passbrains.com/dashboard/view-ticket.php?ticket_no=ACH-159

Environment

Windows + Vista 64bit + Chrome + English
ABP version Chrome build 1.8.12.1396

How to reproduce

  1. Install latest ABP extension on Chrome
  1. Load page http://plasticpollutioncoalition.org/
  1. Right click on the image shown by red circle in screenshot (in the Twitter feed) and select 'Block Element'.
  1. Observe the Add filter dialog does not appear as expected.
  1. Right click anywhere outside of the Twitter feed. The browser context menu appears as expected.
  1. Now right click the same image inside of the Twitter feed.
  1. Observe the Add filter dialog now appears but contains a filter targetting and is highlighting whatever was right clicked at Step 5.

Observed behaviour

At Step 3 the "Add filter" dialog does not appear every time.

After performing Step 5 and attempting to perform Step 3 again the "Add filter" dialog does appear but contains a filter pointing at a different element to the one clicked.

Expected behaviour

The "Add filter" dialog should always appear after the context menu is selected and the filter should be targeting the correct element.

Attachments (1)

3668_1426787862_filter-dialog.jpg (158.4 KB) - added by passbrains 4 years ago.

Download all attachments as: .zip

Change History (5)

Changed 4 years ago by passbrains

comment:1 Changed 4 years ago by passbrains

1 - 24 Mar 2015 14:12:13 posted by Ross Green
Reproduced.

  1. After loading the page the initial right click on the image in the Twitter feed > Block element does not display the Add filter dialog.
  1. Then right clicking anywhere else on the page brings up the normal context menu for that click as expected.
  1. Then right clicking the same image in the Twitter feed > Block element *does* show the Add filter dialog.
  1. However the dialog now contains the a filter pointing at the element selected in my Step 2.

Chrome 40.0.2214.93 / Windows Vista x64 / ABP Build: 1.8.12.1401

comment:2 Changed 4 years ago by Ross

  • Description modified (diff)
  • Summary changed from Add filter does not come up and requires extra operation. to Add filter dialog does not appear and contains incorrect filter

Improved main steps / expected results sections.

comment:3 Changed 4 years ago by mapx

  • Cc sebastian mapx added
  • Component changed from Unknown to Platform

comment:4 Changed 4 years ago by sebastian

  • Resolution set to duplicate
  • Status changed from new to closed

This should be fixed with #2216.

Note: See TracTickets for help on using tickets.