Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#2211 closed change (fixed)

Intercept clicks on links to subscribe.adblockplus.org on Firefox

Reported by: greiner Assignee: greiner
Priority: P3 Milestone: Adblock-Plus-2.6.10-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: #2208 Platform: Firefox
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5309182173511680/

Description

Background

See #2208

What to change

Make the following changes in onBrowserClick() in lib/ui.js:

  • Don't return early just because the link doesn't use the "abp:" protocol
  • Intercept links for the subscribe.adblockplus.org domain by adding an additional check similar to the one checking for "abp:subscribe"
  • subscribe.adblockplus.org links should be treated similarly to "abp:subscribe" links (i.e. they should support the same parameters)

What to test

  • Clicking on the "like this one" link at https://adblockplus.org/en/abp_linkfactory should open the options page with filter list title and URL already filled in
  • Clicking on this link should open the options page with filter list title and URL already filled in
  • Clicking on this link or any other regular link should follow the URL that's specified in the link

Change History (7)

comment:1 Changed 5 years ago by trev

  • Platform changed from Unknown to Firefox/Firefox Mobile
  • Priority changed from Unknown to P3
  • Ready set

comment:2 Changed 5 years ago by greiner

  • Owner set to greiner

comment:3 Changed 5 years ago by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 5 years ago by philll

  • Platform changed from Firefox/Firefox Mobile to Firefox

Made Firefox and Firefox mobile available as seperate platforms.

comment:5 Changed 4 years ago by greiner

  • Resolution set to fixed
  • Status changed from reviewing to closed
  • Tester set to Unknown

comment:6 Changed 4 years ago by Compuitguy

Should the Milestone be Adblock-Plus-for-Firefox-next or it isn't planned ?

comment:7 Changed 4 years ago by greiner

  • Milestone set to Adblock-Plus-for-Firefox-next
Note: See TracTickets for help on using tickets.