Opened on 03/24/2015 at 05:48:23 PM

Closed on 07/20/2015 at 02:40:41 PM

Last modified on 07/22/2015 at 09:32:46 AM

#2211 closed change (fixed)

Intercept clicks on links to on Firefox

Reported by: greiner Assignee: greiner
Priority: P3 Milestone: Adblock-Plus-2.6.10-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: #2208 Platform: Firefox
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):



See #2208

What to change

Make the following changes in onBrowserClick() in lib/ui.js:

  • Don't return early just because the link doesn't use the "abp:" protocol
  • Intercept links for the domain by adding an additional check similar to the one checking for "abp:subscribe"
  • links should be treated similarly to "abp:subscribe" links (i.e. they should support the same parameters)

What to test

  • Clicking on the "like this one" link at should open the options page with filter list title and URL already filled in
  • Clicking on this link should open the options page with filter list title and URL already filled in
  • Clicking on this link or any other regular link should follow the URL that's specified in the link

Attachments (0)

Change History (7)

comment:1 Changed on 03/31/2015 at 02:32:12 PM by trev

  • Platform changed from Unknown to Firefox/Firefox Mobile
  • Priority changed from Unknown to P3
  • Ready set

comment:2 Changed on 03/31/2015 at 05:13:50 PM by greiner

  • Owner set to greiner

comment:3 Changed on 04/01/2015 at 12:00:27 PM by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 05/20/2015 at 02:22:39 PM by philll

  • Platform changed from Firefox/Firefox Mobile to Firefox

Made Firefox and Firefox mobile available as seperate platforms.

comment:5 Changed on 07/20/2015 at 02:40:41 PM by greiner

  • Resolution set to fixed
  • Status changed from reviewing to closed
  • Tester set to Unknown

comment:6 Changed on 07/21/2015 at 11:01:29 PM by Compuitguy

Should the Milestone be Adblock-Plus-for-Firefox-next or it isn't planned ?

comment:7 Changed on 07/22/2015 at 09:32:46 AM by greiner

  • Milestone set to Adblock-Plus-for-Firefox-next

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from greiner.
Note: See TracTickets for help on using tickets.