Opened 5 years ago

Closed 5 years ago

#2212 closed change (fixed)

Intercept clicks on links to subscribe.adblockplus.org on Chrome/Opera/Safari

Reported by: greiner Assignee: sebastian
Priority: P4 Milestone: Adblock-Plus-1.9-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By:
Blocking: #2208 Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5246523029848064

Description

Background

See #2208

What to change

Make the following changes in the document "click" event handler in include.postload.js:

  • Don't return just because the link doesn't use the "abp:" protocol
  • Intercept links matching /^https?:\/\/subscribe\.adblockplus\.org by adding an additional check similar to the one checking for "abp:subscribe"
  • subscribe.adblockplus.org links should be treated similarly to "abp:subscribe" links (i.e. they should support the same parameters)

What to test

  • Clicking on the "like this one" link at https://adblockplus.org/en/abp_linkfactory should open the options page with filter list title and URL already filled in
  • Clicking on this link should open the options page with filter list title and URL already filled in
  • Clicking on this link or any other regular link should follow the URL that's specified in the link

Change History (3)

comment:1 Changed 5 years ago by sebastian

  • Owner set to sebastian
  • Ready set

comment:2 Changed 5 years ago by sebastian

  • Priority changed from Unknown to P4
  • Review URL(s) modified (diff)

comment:3 Changed 5 years ago by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.