Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#2214 closed change (fixed)

Add message to Adblock Plus home page about mobile beta launch

Reported by: annlee@… Assignee: saroyanm
Priority: P2 Milestone:
Module: Websites Keywords:
Cc: Blocked By: #2213
Blocking: #2436 Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: yes
Review URL(s):

http://codereview.adblockplus.org/4726834268733440/
http://codereview.adblockplus.org/6193426550751232/
http://codereview.adblockplus.org/4992283212513280/

Description (last modified by annlee@…)

Background

The message tells people about the mobile browser beta launch.

What to change

The following change may not go live until PR announces the beta / press release. This issue will be updated accordingly.

At http://adblockplus.org, add a text message as shown in the attached layout and style guide to be displayed to users in all languages.

The text of the message shall be: Be the first to experience the new Adblock Browser for smartphones and tablets. Get it here.

The 'Get it here' shall be a hyperlink, and link to the landing page being created by #2213

Additional Notes

The message should not go live until PR announces the beta / press release. Tentatively, this is around May 19 (a Tuesday). Code freeze is May 6. I will update the ticket as soon as these dates are finalized.

Attachments (2)

beta release - homepage 2.png (216.5 KB) - added by annlee@… 5 years ago.
beta release - homepage 3 styleguide.png (224.4 KB) - added by annlee@… 5 years ago.

Download all attachments as: .zip

Change History (27)

Changed 5 years ago by annlee@…

comment:1 Changed 5 years ago by annlee@…

  • Description modified (diff)

comment:2 follow-up: Changed 5 years ago by saroyanm

add this message

I would really like to have the message in the ticket, because it's not selectable in the image, it will reduce the chance to misspell it.

should appear just above the fold

What do you mean by fold ?

comment:3 Changed 5 years ago by annlee@…

  • Description modified (diff)

comment:4 follow-up: Changed 5 years ago by philll

@Ann-lee: When writing issues, please always imagine, you are telling the next random person passing by the street what's written in the "what to change" section. If that random person perfectly withtout any sort of question understood what you wanted, the description is fine.

I really put on question, whether this works with the current what to change section.

Also, please attach ALL files neccessary to fix an issue directly in the issue AND link them in your description. Texts should be directly within the description itself, as that has a version history.

comment:5 in reply to: ↑ 2 Changed 5 years ago by annlee@…

Replying to saroyanm:

add this message

I would really like to have the message in the ticket, because it's not selectable in the image, it will reduce the chance to misspell it.

text added to ticket

should appear just above the fold

What do you mean by fold ?

never mind, sorry for confusion, deleted this part

Changed 5 years ago by annlee@…

comment:6 in reply to: ↑ 4 Changed 5 years ago by annlee@…

Replying to philll:

@Ann-lee: When writing issues, please always imagine, you are telling the next random person passing by the street what's written in the "what to change" section. If that random person perfectly withtout any sort of question understood what you wanted, the description is fine. I really put on question, whether this works with the current what to change section.

I'm new to this, and have not opened many tickets yet, so obviously there will be problems. What would help me are specific corrections, as @saroyanm has already done.

A general 'lecture' such as this will not help the situation nor help me improve my tickets. Is there something else that's lacking beyond what @saroyanm has already commented on?

Also, please attach ALL files neccessary to fix an issue directly in the issue AND link them in your description. Texts should be directly within the description itself, as that has a version history.

done

comment:7 Changed 5 years ago by annlee@…

  • Description modified (diff)
  • Summary changed from Message on ABP.org home page about mobile beta launch to Add message to Adblock Plus home page about mobile beta launch

comment:8 Changed 5 years ago by annlee@…

  • Description modified (diff)

comment:9 follow-up: Changed 5 years ago by philll

  • Description modified (diff)

I cleaned up your description a bit. Please check whether everything is still correct.

comment:10 Changed 5 years ago by annlee@…

  • Description modified (diff)

comment:11 in reply to: ↑ 9 Changed 5 years ago by annlee@…

Replying to philll:

I cleaned up your description a bit. Please check whether everything is still correct.

Thanks @philll, looks good.

Had to sort out some issues with PR & legal today, which affected this ticket, hence my delay in updating.

The change (which is already reflected in the Background and What to change), is that we no longer need to limit the message to english-speaking users, as explained in discourse

comment:12 Changed 5 years ago by philll

  • Description modified (diff)

Fixed the attachment links that contain way too many whitepsaces.

comment:13 Changed 5 years ago by saroyanm

  • Description modified (diff)
  • Priority changed from Unknown to P2
  • Ready set

comment:14 Changed 4 years ago by saroyanm

  • Description modified (diff)

comment:15 Changed 4 years ago by saroyanm

  • Owner set to saroyanm

comment:16 Changed 4 years ago by annlee@…

  • Description modified (diff)

comment:18 Changed 4 years ago by saroyanm

  • Review URL(s) modified (diff)

comment:19 Changed 4 years ago by saroyanm

  • Status changed from new to reviewing

comment:20 Changed 4 years ago by saroyanm

  • Blocking 2436 added

comment:24 Changed 4 years ago by Ross

The message has been added to the home page and looks the same across browsers. After applying the style diff's correctly it looks fine.

Tested with:

IE8.0.6001Windows XP
IE9.0.8112Windows 7
IE10.0.9200Windows 7
IE11.0.9600Windows 8.1
Chrome42.0.2311.135Windows 8.1
Opera29.0.1795.47Windows 8.1
Firefox37.0.2Windows 8.1
Chrome42.0.3211.111Android 4.2.2
Last edited 4 years ago by philll (previous) (diff)

comment:25 Changed 4 years ago by Ross

Re-tested Adblock Browser pages as part of the CMS (instead of Anwiki). Message is displayed correctly as expected.

A related bug affects these specific pages in IE8: #2515

Tested with:
cms / r42
web.adblockplus.org / r86 (with patches)

Tested on:

IE8.0.6001Windows XP
IE9.0.8112Windows 7
IE10.0.9200Windows 7
IE11.0.9600Windows 8.1
Chrome42.0.2311.135Windows 8.1
Opera29.0.1795.47Windows 8.1
Firefox37.0.2Windows 8.1
Chrome42.0.3211.111Android 4.2.2

comment:26 Changed 4 years ago by Ross

  • Verified working set

comment:27 Changed 4 years ago by saroyanm

  • Review URL(s) modified (diff)

comment:28 Changed 4 years ago by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:29 Changed 4 years ago by fhd

  • Sensitive unset
Note: See TracTickets for help on using tickets.