Opened on 03/27/2015 at 01:22:33 PM
Closed on 08/26/2015 at 01:07:13 PM
#2222 closed defect (fixed)
ABP fails to send issue report (error code 404)
| Reported by: | arthur | Assignee: | matze |
|---|---|---|---|
| Priority: | P1 | Milestone: | |
| Module: | Infrastructure | Keywords: | |
| Cc: | fred, arthur, greiner | Blocked By: | |
| Blocking: | #2226, #2526 | Platform: | Unknown |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by philll)
Environment
Windows 8.1 Pro
Firefox 36.0.4
ABP 2.6.8
How to reproduce
- Go to http://adblockplus.org
- Click the ABP icon in top right corner
- Select "Report issue on this page"
- Choose "Other Issue"
- Click the "Next" button
- Check the checkbox and click the "Next" button
- Click the "Next" button again
- Check the "Anonymous submission" checkbox
- Click the "Send report" button
Observed behaviour
The issue report cannot be sent, an [abp_report.png HTTP 404 message is shown].
Expected behaviour
The issue report should be sent.
Attachments (1)
Change History (14)
Changed on 03/27/2015 at 01:22:54 PM by arthur
comment:1 Changed on 03/27/2015 at 01:24:22 PM by arthur
- Description modified (diff)
- Summary changed from ABP fails to send issue report to ABP fails to send issue report (error code 404)
comment:2 Changed on 03/27/2015 at 05:18:45 PM by greiner
- Component changed from Adblock-Plus-for-Firefox to Infrastructure
- Platform changed from Firefox/Firefox Mobile to Unknown
comment:3 Changed on 03/30/2015 at 08:18:11 AM by philll
- Description modified (diff)
- Priority changed from Unknown to P1
comment:4 Changed on 03/30/2015 at 09:49:34 AM by matze
- Cc fred added
- Owner set to matze
- Ready set
comment:5 Changed on 03/30/2015 at 11:23:31 AM by matze
- Blocking 2226 added
comment:6 Changed on 03/30/2015 at 11:24:40 AM by matze
- Cc arthur added
comment:7 Changed on 03/30/2015 at 02:02:19 PM by greiner
- Cc greiner added
comment:8 Changed on 03/30/2015 at 10:59:26 PM by matze
This issue has been hot-fixed today afternoon.
Tests with @arthur show that new issues have been submitted in the meantime, though we did not find two of my self-triggered test issues. We will check back on that in the summary tomorrow. If it worked as intended, a persistent version of the fix is going to review tomorrow.
comment:9 Changed on 03/31/2015 at 07:14:19 AM by famlam
I can confirm that I today have received my digests again (for EL, ELD, ELG, EP, Social, Annoyances and AWRL)
comment:10 Changed on 03/31/2015 at 06:39:58 PM by matze
- Review URL(s) modified (diff)
- Status changed from new to reviewing
The patch set has just been published, after verifying the changes in a local replica of the server.
Notes for the future:
In order to avoid accidental overrides, the include fastcgi_params; directive - if present - should always preceed any additional fastcgi_param ...;.
Also, we should update the configuration to use fascgi_split_path_info ...; instead of manually setting SCRIPT_FILENAME, SCRIPT_NAME, PATH_INFO or PATH_TRANSLATED (which then must precede the inclusion of the fastcgi_params file).
comment:11 Changed on 05/15/2015 at 10:18:09 AM by matze
- Review URL(s) modified (diff)
comment:12 Changed on 05/15/2015 at 10:28:27 AM by matze
- Blocking 2526 added
comment:13 Changed on 08/26/2015 at 01:07:13 PM by matze
- Resolution set to fixed
- Status changed from reviewing to closed
- Tester set to Unknown
I didn't see any changes regarding this in our extension and this issue also appears with Adblock Plus 2.6 which was released roughly a year ago. Therefore my assumption is that this is a server-side issue in Infrastructure (or otherwise in Sitescripts).