Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#2232 closed change (fixed)

Get rid of conditional catch clauses

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone: Adblock-Plus-2.6.10-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: trev Blocked By:
Blocking: #312, #2231 Platform: Firefox
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/6263536791584768

Description (last modified by trev)

Background

We currently use a conditional catch clause in lib/contentPolicy.js. However, conditional catch clauses are non-standard and JsDoc 3.3.0 is unable to parse them.

What to change

Catch the error unconditionally. For the factory registration failure proceed as before, all other errors should simply be reported.

Change History (6)

comment:1 Changed 3 years ago by sebastian

  • Blocking 312 added; 321 removed

comment:2 Changed 3 years ago by trev

  • Description modified (diff)
  • Platform changed from Unknown to Firefox/Firefox Mobile
  • Priority changed from Unknown to P3
  • Ready set

comment:3 Changed 3 years ago by sebastian

  • Owner set to sebastian

comment:4 Changed 3 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 3 years ago by sebastian

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed 3 years ago by philll

  • Platform changed from Firefox/Firefox Mobile to Firefox

Made Firefox and Firefox mobile available as seperate platforms.

Note: See TracTickets for help on using tickets.