Opened 5 years ago

Last modified 5 years ago

#2232 closed change

Get rid of conditional catch clauses — at Version 2

Reported by: sebastian Assignee:
Priority: P3 Milestone: Adblock-Plus-2.6.10-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: trev Blocked By:
Blocking: #312, #2231 Platform: Firefox
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/6263536791584768

Description (last modified by trev)

Background

We currently use a conditional catch clause in lib/contentPolicy.js. However, conditional catch clauses are non-standard and JsDoc 3.3.0 is unable to parse them.

What to change

Catch the error unconditionally. For the factory registration failure proceed as before, all other errors should simply be reported.

Change History (2)

comment:1 Changed 5 years ago by sebastian

  • Blocking 312 added; 321 removed

comment:2 Changed 5 years ago by trev

  • Description modified (diff)
  • Platform changed from Unknown to Firefox/Firefox Mobile
  • Priority changed from Unknown to P3
  • Ready set
Note: See TracTickets for help on using tickets.