Changes between Version 11 and Version 14 of Ticket #2234


Ignore:
Timestamp:
04/06/2015 10:29:57 AM (5 years ago)
Author:
sebastian
Comment:

Replying to trev:

Replying to sebastian:

I changed the path of the script to /formsubscribe for consistency with /formmail.

"formmailer" is a common term. I think the original suggestion (/submitEmail) makes more sense, /formsubscribe is just weird.

Fair enough.

I realized that we will be putting unverified email addressed into that list, is this really a good idea? I think we need to send people an email and only add the email address if they click a link there.

Yes, we are storing unverified email addresses. However, email verification would add unneeded complexity, requires additional designs and texts, and would ultimately reduce the number of users going through the process of submitting and verifying their email address.

Is there a particular reason, you think we have to make sure that the email address exists and belongs to the user who submitted it, before sending the actual notification? Shouldn't make any difference whether sending a verification email or the actual notification to an unverified email address, right?

Finally, does this really belong in the sitescripts repository? fhd wanted to keep functionality related to Adblock Browser out of it for now, we can have external web handlers. The code itself doesn't seem to mention Adblock Browser, so if the commit message doesn't do it either this should be fine.

Yes, the code doesn't mention Adblock Browser, neither did I plan to mention it in the commit message. So what are we talking about here?

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #2234

    • Property Cc fhd added
    • Property Blocking changed from 2213 to 2213, 2267
  • Ticket #2234 – Description

    v11 v14  
    77 
    88=== What to change === 
    9 Implement a WSGI app served by the multiplexer under `/formsubscribe` handling email addresses sent as form data in a `POST` request. The email address will be given by the `email` form field (one email address per request). Those email addresses must be stored in a persistent file on the disk, one line per email address (this will be compatible with CVS). Moreover, the file needs to be locked for writing to avoid problems when concurring requests try to access it at the same time. Once the email address were successfully stored a response with the text "Thanks for your submission! We'll notify you before the launch." should be sent. 
     9Implement a WSGI app served by the multiplexer under `/submitEmail` handling email addresses sent as form data in a `POST` request. The email address will be given by the `email` form field (one email address per request). Those email addresses must be stored in a persistent file on the disk, one line per email address (this will be compatible with CVS). Moreover, the file needs to be locked for writing to avoid problems when concurring requests try to access it at the same time. Once the email address were successfully stored a response with the text "Thanks for your submission! We'll notify you before the launch." should be sent.