Opened 5 years ago

Closed 5 years ago

Last modified 3 months ago

#2235 closed change (fixed)

[JSHydra] Update jsshell to ESR31 to support new generator syntax

Reported by: trev Assignee: sebastian
Priority: P3 Milestone:
Module: Automation Keywords:
Cc: Blocked By:
Blocking: #1602 Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5915403922440192

Description (last modified by sebastian)

Background

Currently, JSHydra will convert Mozilla-specific generators into functions returning arrays. E.g. original function is:

function foo()
{
  yield "bar";
}

This becomes:

function foo()
{
  var result = [];
  result.push("bar");
  return result;
}

However, the standard-compliant syntax for generator functions looks like:

function foo*()
{
  yield "bar";
}

So we have to update Mozilla's jsshell used by jshydra to parse the

What to change

Update Mozilla's jsshell, downloaded on-the-fly when using jshydra, to support the new generator syntax.

Change History (7)

comment:1 Changed 5 years ago by sebastian

  • Priority changed from Unknown to P3
  • Ready set

comment:2 Changed 5 years ago by sebastian

  • Description modified (diff)
  • Owner set to sebastian

comment:3 Changed 5 years ago by sebastian

  • Summary changed from [JSHydra] Convert ES6 generators to regular functions to [JSHydra] Update jsshell to ESR31 to support new generator syntax

comment:4 Changed 5 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 5 years ago by sebastian

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed 4 years ago by sebastian

  • Blocking 2425 added

comment:7 Changed 4 years ago by sebastian

  • Blocking 2425 removed
Note: See TracTickets for help on using tickets.