Opened on 03/30/2015 at 02:38:52 PM

Closed on 03/30/2015 at 02:41:23 PM

#2236 closed change (fixed)

Adapt inline type annotations for JsDoc 3

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone: Adblock-Plus-2.6.9-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: #2231 Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

​http://codereview.adblockplus.org/6309488109813760/

Description

Background

There is a ​bug in JsDoc 3, which leads to a crash when encountering methods with more than on inline-documented argument.

What to change

Work around the bug in JsDoc 3, by using the @param tag instead inline annotations where needed.

Attachments (0)

Change History (2)

comment:1 Changed on 03/30/2015 at 02:39:08 PM by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 03/30/2015 at 02:41:23 PM by sebastian

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

​https://hg.adblockplus.org/adblockplus/rev/ea757aca0140

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from sebastian.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.