Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#2237 closed change (fixed)

Add unit tests for notification opt-out

Reported by: greiner Assignee: greiner
Priority: P2 Milestone:
Module: Extensions-for-Adblock-Plus Keywords:
Cc: Blocked By: #2192
Blocking: #2191 Platform: Unknown
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5654617534758912/

Description (last modified by trev)

Background

In #2191 we added opt-out capabilities for notifications which should be tested to make sure they don't interfere with the existing handling of notifications.

What to change

The following new scenarios should be tested:

  • Calling Notification.getNextToShow() should return critical notifications after the "*" category was put into list of ignored categories using the method provided in #2192
  • Calling Notification.getNextToShow() should ignore information notifications after the "*" category was put into list of ignored categories using the method provided in #2192
  • extensions.adblockplus.notifications_showui should be set to true after calling the method provided in #2192 for toggling category visibility

Change History (4)

comment:1 Changed 4 years ago by trev

  • Description modified (diff)
  • Priority changed from Unknown to P2
  • Ready set

comment:2 Changed 4 years ago by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 4 years ago by greiner

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed 4 years ago by trev

  • Component changed from Adblock-Plus-for-Firefox to Extensions-for-Adblock-Plus
  • Tester set to Unknown
Note: See TracTickets for help on using tickets.