Opened 4 years ago

Last modified 4 years ago

#2237 closed change

Add unit tests for notification opt-out — at Initial Version

Reported by: greiner Assignee: greiner
Priority: P2 Milestone:
Module: Extensions-for-Adblock-Plus Keywords:
Cc: Blocked By: #2192
Blocking: #2191 Platform: Unknown
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5654617534758912/

Description

Background

In #2191 we added opt-out capabilities for notifications which should be tested to make sure they don't interfer with the existing handling of notifications.

What to change

  • Calling Notification.getNextToShow() should return critical notifications after the "all" category was put into list of ignored categories using the method provided in #2192
  • Calling Notification.getNextToShow() should ignore information notifications after the "all" category was put into list of ignored categories using the method provided in #2192
  • extensions.adblockplus.notifications_showcheckbox should be set to true after calling the method provided in #2192 for toggling category visibility

Change History (0)

Note: See TracTickets for help on using tickets.