Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#2277 closed change (fixed)

[Send notifications to a subset of the user base] Use the new notification.json handler

Reported by: fhd Assignee: fhd
Priority: P2 Milestone:
Module: Infrastructure Keywords:
Cc: Kirill Blocked By: #2276, #2880
Blocking: #2162, #2313, #2314, #2365 Platform: Unknown
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

http://codereview.adblockplus.org/6380170118168576/

Description

Background

See #2162.

What to change

#2276 provides a new handler for notification.json requests that can handle groups. We need to use that one on the notification servers (should be rolled out gradually and tested carefully). We most definitely need to cache the response as discussed in #2162.

Change History (10)

comment:1 Changed 4 years ago by fhd

  • Blocked By 2276 added
  • Blocking 2162 added

comment:2 Changed 4 years ago by fhd

  • Owner set to fhd

comment:3 Changed 4 years ago by fhd

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 4 years ago by matze

  • Blocking 2313 added

comment:5 Changed 4 years ago by matze

  • Blocking 2314 added

comment:6 Changed 4 years ago by fhd

  • Blocking 2365 added

comment:7 Changed 4 years ago by Kirill

  • Cc Kirill added

comment:8 Changed 4 years ago by Ross

  • Tester set to Ross
  • Verified working set

This was implemented/done. The new handler appears to be working as expected however is was tested without caching for now. I've created to test with caching enabled (#2739).

comment:9 Changed 4 years ago by fhd

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:10 Changed 4 years ago by matze

  • Blocked By 2880 added
Note: See TracTickets for help on using tickets.