Opened 5 years ago

Closed 5 years ago

#2279 closed defect (fixed)

Multiple dialogs shown when using "Block element" from context menu

Reported by: passbrains Assignee: sebastian
Priority: P3 Milestone: Adblock-Plus-1.9-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: mapx, sebastian Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5845725862690816

Description (last modified by sebastian)

Adapted from https://www.passbrains.com/dashboard/view-ticket.php?ticket_no=AOP-211

Environment

Windows + 8 64bit + Opera + English
ABP version 1.8.12.1407

How to reproduce

  1. Install ABP extension.
  2. Load website http://timesofindia.indiatimes.com
  3. Right-click on any image and select "Block Element".
  4. Without clicking "Add" or "Cancel", Right-click on another image and select "Block Element".
  5. Move the "Add filters" dialog box. Observe that multiple dialogs are displayed.
  6. Observe that Add or Cancel on last "Add filters" dialog box works.
  7. Click "Add" or "Cancel" on first "Add filters" dialog box.

Observed behaviour

Filter is added by clicking Add on first "Add filters" dialog box but dialog box is not closed either by clicking "Add" or "Cancel".
 

Expected behaviour

There should only be one dialog. Selecting another element or clicking the "Add" or "Cancel" button should close the current dialog.

Attachments (1)

3766_1428058928_operaMultiple.mp4 (1.3 MB) - added by passbrains 5 years ago.

Download all attachments as: .zip

Change History (9)

Changed 5 years ago by passbrains

comment:1 Changed 5 years ago by passbrains

1 - 06 Apr 2015 13:22:09 posted by Ross Green
Reproduced as described.

Multiple Add filter dialogs are opened and after the last opened is closed, the previous dialog can be interacted with but doesn't respond.

Opera 28.0.1750.48 / Windows 8 x64 / ABP: 1.8.12.1407

comment:2 Changed 5 years ago by mapx

  • Description modified (diff)

I can reproduce the issue for chrome too.

comment:3 Changed 5 years ago by mapx

  • Cc mapx sebastian added
  • Component changed from Unknown to Platform

comment:4 Changed 5 years ago by sebastian

  • Description modified (diff)
  • Platform changed from Opera to Unknown
  • Priority changed from Unknown to P3
  • Ready set
  • Summary changed from 'Add filters' dialog box is not closed when clicked on either 'Add' or 'Cancel'. to Multiple dialogs shown when using "Block element" from context menu

Reproduced and tracked down to #2080 introducing this regression.

comment:5 Changed 5 years ago by sebastian

  • Description modified (diff)

comment:6 Changed 5 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:7 Changed 5 years ago by sebastian

  • Owner set to sebastian

comment:8 Changed 5 years ago by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.