Opened on 03/28/2014 at 01:10:43 PM

Closed on 05/08/2014 at 01:48:27 PM

Last modified on 05/09/2014 at 06:19:56 AM

#227 closed defect (fixed)

Element hiding selection by mouse wheel broken

Reported by: arthur Assignee: trev
Priority: P4 Milestone: Element-Hiding-Helper-1.3.1
Module: Extensions-for-Adblock-Plus Keywords:
Cc: trev Blocked By:
Blocking: Platform:
Ready: yes Confidential: no
Tester: Verified working: yes
Review URL(s):



  • Firefox 28
  • Windows 8.1 Pro x64
  • Adblock Plus
  • Element Hiding Helper 1.2.4a.453

How to reproduce

  1. Start element hiding selection.
  2. Select an element (do not click, just hover).
  3. Press Shift and scroll down with the mouse wheel.

Observed behaviour

Selection jumps directly to the last node (##HTML).

Expected behaviour

It should select the next parent node.

Forum topic

Attachments (1)

elemhidehelper- (105.3 KB) - added by trev on 04/30/2014 at 10:05:43 PM.
Test build

Download all attachments as: .zip

Change History (12)

comment:1 Changed on 04/30/2014 at 03:38:25 PM by philll

  • Resolution set to worksforme
  • Status changed from new to closed

Works for me with both, ABP stable 2.5.1 and EMH stable 1.2.3 as well as ABP and Tested at

comment:2 Changed on 04/30/2014 at 04:04:22 PM by arthur

  • Cc trev added

I have found the cause. I always increase the number of lines the mouse wheel should scroll with one notch in the mouse wheel settings. Not sure what the exact relation between the number and the selected element is though.

Wladimir, could this be made independently?

comment:3 Changed on 04/30/2014 at 10:02:23 PM by trev

So I guess that your mouse is configured to generate multiple scroll events each time you use the mouse wheel. I'm not sure we can do much about that - other than maybe enforcing a particular time interval between the "wider" commands that are being triggered there.

Changed on 04/30/2014 at 10:05:43 PM by trev

Test build

comment:4 Changed on 04/30/2014 at 10:07:03 PM by trev

  • Priority changed from P5 to P4
  • Ready set
  • Resolution worksforme deleted
  • Status changed from closed to reopened

Actually, it might be a wrong implementation in Element Hiding Helper after all. Could you test the build I attached and tell me whether the issue is fixed there?

comment:5 Changed on 04/30/2014 at 10:07:10 PM by trev

  • Owner set to trev

comment:6 Changed on 05/01/2014 at 09:06:51 AM by arthur

  • Resolution set to fixed
  • Status changed from reopened to closed
  • Verified working set

Yay, it's working for me. :)

comment:7 Changed on 05/01/2014 at 11:27:04 AM by trev

  • Resolution fixed deleted
  • Status changed from closed to reopened

No, not fixed - this was merely a test, not even reviewed yet.

comment:8 Changed on 05/01/2014 at 11:32:05 AM by trev

  • Review URL(s) modified (diff)
  • Status changed from reopened to reviewing

comment:9 Changed on 05/01/2014 at 12:11:45 PM by arthur

Whoops, you're right of course. Sorry!

comment:10 Changed on 05/08/2014 at 01:48:27 PM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:11 Changed on 05/09/2014 at 06:19:56 AM by trev

  • Milestone set to Element-Hiding-Helper-next

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Note: See TracTickets for help on using tickets.