Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#229 closed defect (fixed)

[Australis] "Select element to hide" not visible when icon is placed in the menu

Reported by: arthur Assignee: saroyanm
Priority: P2 Milestone: Element-Hiding-Helper-1.3
Module: Extensions-for-Adblock-Plus Keywords:
Cc: trev Blocked By:
Blocking: Platform:
Ready: yes Confidential: no
Tester: Verified working: yes
Review URL(s):

http://codereview.adblockplus.org/4734919200735232/

Description (last modified by arthur)

Environment

  • Latest Nightly
  • Windows 8.1 Pro x64
  • Adblock Plus 2.5.1.3788
  • Element Hiding Helper 1.2.4a.453

How to reproduce

  1. Customize the appearance of Firefox via right-clicking on the tab bar
  2. Drag the ABP icon to the menu like shown in the screenshot

Observed behaviour

When you click the icon, "Select element to hide" is missing in the context menu.

Expected behaviour

It should be visible.

Forum topic

https://adblockplus.org/forum/viewtopic.php?f=11&t=21466

Attachments (1)

ehh.png (101.2 KB) - added by arthur 6 years ago.

Download all attachments as: .zip

Change History (10)

Changed 6 years ago by arthur

comment:1 Changed 6 years ago by arthur

  • Description modified (diff)

comment:2 Changed 6 years ago by arthur

  • Ready set

comment:3 Changed 6 years ago by saroyanm

  • Owner set to saroyanm
  • Status changed from new to assigned

comment:4 Changed 6 years ago by saroyanm

  • Review URL(s) modified (diff)
  • Status changed from assigned to reviewing

comment:5 Changed 6 years ago by trev

  • Cc trev added

As noted in the review, the same issue affects Diagnostics and Crawler extensions as well.

comment:6 Changed 6 years ago by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed

Fixed for Diagnostics and Crawler as well.

comment:7 Changed 6 years ago by arthur

  • Verified working set

comment:9 Changed 6 years ago by trev

  • Milestone set to Element-Hiding-Helper-next
Note: See TracTickets for help on using tickets.