Changes between Version 1 and Version 2 of Ticket #2296


Ignore:
Timestamp:
04/09/2015 06:28:51 PM (5 years ago)
Author:
sebastian
Comment:

My assumptions here weren't quite right. Though using io.open() instead makes sense for new code, but this isn't worth changing the existing code. The prospect of breaking something and the afford properly testing the change would be too large.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #2296

    • Property Status changed from reviewing to closed
    • Property Resolution changed from to rejected
  • Ticket #2296 – Description

    v1 v2  
    22`codecs.open()` has been superseded by `io.open()`. Beside beeing newer, `io.open()` if used in text mode, also enforces the written data to be unicode objects, preventing accidental encoding issues. 
    33 
    4 Moreover, some code currently uses `codecs.open()` while binary data actually sent or expected. That code will currently result in encoding errors when encountering non-ASCII charecters. 
     4~~Moreover, some code currently uses `codecs.open()` while binary data actually sent or expected. That code will currently result in encoding errors when encountering non-ASCII characters.~~ 
    55 
    66=== What to change === 
  • Ticket #2296 – Review URL(s)

    v1 v2  
    1 http://codereview.adblockplus.org/4794078424203264