Opened 5 years ago

Closed 5 years ago

#2297 closed change (fixed)

Call chrome.webRequst.behaviorChanged() only for request filter changes

Reported by: sebastian Assignee: sebastian
Priority: P4 Milestone: Adblock-Plus-1.9-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/4938965924708352

Description

Background

Currently chrome.webRequst.behaviorChanged() is called on every filter change. However, only request blocking/whitelisting filters have an effext on the webRequest handler behavior. Hence this expeensive function is potentially called more often than required.

What to change

Don't call chrome.webRequst.behaviorChanged() when other filters than request blocking/whitelisting filters have been added/removed.

Change History (3)

comment:1 Changed 5 years ago by sebastian

  • Summary changed from Call chrome.webRequst.behaviorChanged() only for request filters to Call chrome.webRequst.behaviorChanged() only for request filter changes

comment:2 Changed 5 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 5 years ago by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.