Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#2299 closed change (fixed)

Create a filter list repository for ads injected by adware

Reported by: arthur Assignee: fhd
Priority: P3 Milestone:
Module: Infrastructure Keywords:
Cc: trev, matze, till Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/4799232384958464/

Description

Background

According to Till we want to block ads injected by adware extension in the future. I need a filter list repository to create that list.

What to change

  • Create a repository on hg.adblockplus.org called "adwarefilters"
  • Add "adwarefilters" to filtermaster configuration
  • Give me access for it
  • The repository shouldn't be listed on hg.adblockplus.org for now

Change History (7)

comment:1 Changed 5 years ago by arthur

Wladimir, I'm not sure if that's really confidential or not. We should be aware that the repository name will be visible i nthe infrastructure repository once it's added to the filtermaster config and the list itself will be visible later in the filter lists stats as well.

Version 0, edited 5 years ago by arthur (next)

comment:2 Changed 5 years ago by arthur

  • Cc till added

comment:3 Changed 5 years ago by fhd

  • Owner set to fhd
  • Priority changed from Unknown to P3
  • Ready set
  • Sensitive unset

Don't see why this should be confidential, unsetting.

I've created the adwarefilters repository, will prepare a patch for adding that to the filtermaster next.

Arthur is the only one with commit access - you'll have to do the initial commit.

comment:4 Changed 5 years ago by fhd

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

Review is up, however, I can't test/push this before the initial commit has happened.

comment:6 Changed 5 years ago by fhd

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:7 Changed 5 years ago by fhd

OK, pushed (https://hg.adblockplus.org/infrastructure/rev/9c5704715ff7) and deployed, should be live in about 5 minutes.

Last edited 5 years ago by fhd (previous) (diff)
Note: See TracTickets for help on using tickets.