Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#2310 closed change (fixed)

ensure_dependencies.py should allow both formats of Git SSH URLs

Reported by: kzar Assignee: kzar
Priority: P4 Milestone:
Module: Automation Keywords:
Cc: sebastian Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/4542760560361472/

Description

Background

GitHub and other similar services often specify the SSH URLs for repositories in a format something like git@github.com:owner/repo.git which is the equivalent of ssh://git@github.com/owner/repo.git. Currently the ensure_dependencies script will only work with URLs in the latter format.

What to change

Update the ensure_dependencies.py script in the buildtools repository so that it supports the common git@github.com:owner/repo.git format of Git SSH URLs.

(For some guidance Sebastian has written how this might be achieved here.)

Change History (5)

comment:1 Changed 5 years ago by sebastian

  • Priority changed from Unknown to P4
  • Ready set

comment:2 Changed 5 years ago by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 5 years ago by kzar

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed 5 years ago by kzar

  • Owner set to kzar
Note: See TracTickets for help on using tickets.