Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#2311 closed change (fixed)

ensure_dependencies.py should fetch and track remote Git branches when required

Reported by: kzar Assignee: kzar
Priority: P4 Milestone:
Module: Automation Keywords:
Cc: sebastian Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/6068640302497792/

Description

Background

The ensure_dependencies.py script does not currently fetch and track remote Git branches before trying to check out the specified revision. This means that it is not easy to specify a branch name as the revision for a dependency during development. You first need to manually track the remote branch and then re-run the script.

What to change

Update the ensure_dependencies.py script in the buildtools repository so that it fetches and tracks _at least_ all the remote branches that are specified in dependency files. (Make sure that is done before attempting to check them out.)

(For some guidance Sebastian has written how this might be achieved here.)

Change History (5)

comment:1 Changed 5 years ago by sebastian

  • Priority changed from Unknown to P4
  • Ready set

comment:2 Changed 5 years ago by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 5 years ago by kzar

  • Owner set to kzar

comment:4 Changed 5 years ago by kzar

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.