Opened 5 years ago

Closed 3 years ago

#2313 closed change (fixed)

Handle Flup dependency in module sitescripts

Reported by: matze Assignee: poz2k4444
Priority: P4 Milestone:
Module: Infrastructure Keywords:
Cc: trev, fhd Blocked By: #2277, #2314
Blocking: Platform: Unknown
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29363535/

Description

When we need multiplexer.fcgi from sitescripts in production, we currently configure it's dependencies (namely package python-flup) manually every time - which not only violates the DRY principle but also implies the requirement for implementation-specific knowledge where it should not be necessary:

$ grep -R python-flup *
modules/updateserver/manifests/init.pp:  package {'python-flup':}
modules/updateserver/manifests/init.pp:      Package["python-flup"],
modules/web/manifests/server.pp:    package {'python-flup':}
modules/web/manifests/server.pp:        Package["python-flup"],

Instead we should either a) introduce a $fcgi_support parameter in modules/sitescripts/manifests/init.pp that triggers the installation of the package, or b) always install that package with module sitescripts.

Change History (7)

comment:1 Changed 5 years ago by fhd

Good idea!

I'm voting for b - I don't see any problem with the sitescripts module installing all of the sitescripts dependencies, whether the parts requiring those are used or not. It's not like we have a lot of dependencies.

Bit of a separate topic, but seeing how we always seem to start the multiplexer with spawn-fcgi - we _might_ want to consider moving that to a define in sitescripts to further simplify things.

comment:2 Changed 5 years ago by matze

  • Ready set

Agreed. I've thought about spawn-fcgi when writing this ticket, but I am not sure whether sitescripts is the best place for that - it's not a dependency, in contrast to python-flup. However, as you wrote already, it's a separate topic. I will take care of a follow-up for that one.

comment:3 Changed 5 years ago by matze

  • Blocked By 2277 added
  • Ready unset

(Let's adress this after #2277 is pushed, in order to avoid confusion and to allow for a single, clean patch-set per issue.)

comment:4 Changed 5 years ago by matze

  • Blocked By 2314 added

comment:5 Changed 3 years ago by poz2k4444

  • Owner set to poz2k4444
  • Review URL(s) modified (diff)
  • Tester set to Unknown

comment:6 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 2313 - Handle Flup dependency in module sitescripts

comment:7 Changed 3 years ago by poz2k4444

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.