Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#2323 closed defect (fixed)

Links aren't being processed properly on the home page

Reported by: trev Assignee: trev
Priority: P3 Milestone:
Module: Sitescripts Keywords:
Cc: Blocked By:
Blocking: #2035 Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: yes
Review URL(s):

http://codereview.adblockplus.org/4802066526502912/
http://codereview.adblockplus.org/4949324312084480/

Description

How to reproduce

  1. Go to https://beta.adblockplus.org/
  2. Check the source code

Observed behaviour

Page links haven't been resolved, e.g. <a href="android"> stayed there as a relative link.

Expected behaviour

The links should have been resolved, e.g. <a href="/en/android">. This behavior is implicit for raw HTML files but has to be requested explicitly in templates like the home page.

Change History (9)

comment:1 Changed 5 years ago by trev

  • Owner set to trev

comment:2 Changed 5 years ago by trev

  • Component changed from Unknown to Sitescripts

comment:3 Changed 5 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

CMS change to make sure that links in translatable strings are always resolved is under review. What's left is links outside translatable strings - the conversion script needs to turn them calls of the linkify filter.

comment:4 Changed 5 years ago by trev

  • Status changed from reviewing to reopened

Fixed the CMS part: https://hg.adblockplus.org/cms/rev/4db7e0c3d360

Rest of it should be resolved in the conversion script.

comment:5 Changed 5 years ago by trev

  • Resolution set to fixed
  • Status changed from reopened to closed

comment:6 Changed 5 years ago by trev

  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening - the solution implemented here is incomplete, we have a problem with images as well.

comment:7 Changed 5 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from reopened to reviewing

Opted for automatic link resolution for templates, same as for other formats.

comment:9 Changed 5 years ago by Ross

  • Verified working set

Fixed.

Tested by:
Checking links/images on beta.adblockplus.org and checking home page links after running conversation script.

web.adblockplus.org / r68
website-converter / master / 105208883c4336a3788820fe9ab379cf639f8387

Note: See TracTickets for help on using tickets.