Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#2325 closed change (fixed)

Add a way to set settings in libadblockplus for FRP and automatic updates

Reported by: oleksandr Assignee: oleksandr
Priority: Unknown Milestone: Adblock-Plus-for-Internet-Explorer-1.5
Module: Libadblockplus Keywords: large-scale-deployments 2015q2
Cc: fhd, sergz, eric, oleksandr, simona Blocked By:
Blocking: #1491, #1605 Platform: Internet Explorer
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5653480979038208/

Description

Background

As of now libadblockplus starts updater automatically on launch (by creating a Downloadable instance with TYPE_AUTOMATIC in updater.js). It also derives firstRun property based on FilterStorage.firstRun. We need a way to override these, in order to support disabling of automatic updates and FRP

What to change

Implement settings for libadblockplus so that it's client would be able to override the automatic update and firstRun setting. There should be default values for those settings, so that updates would start automatically, and FRP will be reported if not set otherwise.

Change History (9)

comment:1 Changed 4 years ago by oleksandr

  • Blocking 1605 added

comment:2 Changed 4 years ago by oleksandr

  • Blocking 1491 added

comment:3 Changed 4 years ago by oleksandr

  • Summary changed from Add a way to settings in libadblockplus for FRP and automatic updates to Add a way to set settings in libadblockplus for FRP and automatic updates

comment:4 Changed 4 years ago by oleksandr

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 4 years ago by simona

  • Blocking 542 added

comment:6 Changed 4 years ago by fhd

  • Blocking 542 removed

Removing #542 from blocking - it's already transitively blocked by this through #1491 and #1605.

comment:7 Changed 4 years ago by fhd

  • Keywords 2015q2 added

comment:8 Changed 4 years ago by oleksandr

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:9 Changed 4 years ago by oleksandr

  • Milestone set to Adblock-Plus-for-Internet-Explorer-1.5
Note: See TracTickets for help on using tickets.