Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#2339 closed change (fixed)

Don't let fixed strings break up translations

Reported by: trev Assignee: kzar
Priority: P3 Milestone:
Module: Unknown Keywords: 2015q2
Cc: kzar Blocked By: #2112
Blocking: #2035 Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: yes
Review URL(s):

https://github.com/kzar/adblockplus-website-converter/commit/342299335eef8331d89e6b26da4be9c1f4a3e0cb

Description

Background

We currently have the following code in our index.tmpl:

<h1>{{"Over"|translate("s46")}} 300 {{"million downloads"|translate("s47")}}</h1>

This is one sentence broken up into two translation, which isn't optimal.

What to change

Adjust the conversion script to use the syntax introduced in #2112:

<h1>{{"Over <fix>300</fix> million downloads"|translate("s46")}}</h1>

Change History (6)

comment:1 Changed 5 years ago by fhd

  • Keywords 2015q2 added

comment:2 Changed 5 years ago by kzar

  • Owner set to kzar

comment:3 Changed 5 years ago by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 5 years ago by kzar

  • Review URL(s) modified (diff)

comment:5 Changed 5 years ago by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed 5 years ago by Ross

  • Verified working set

Fixed.

Tested by:
Checking HTML source on beta.adblockplus.org and checking for <fix> in translatable strings after running the conversion script.

web.adblockplus.org / r68
website-converter / master / 105208883c4336a3788820fe9ab379cf639f8387

Note: See TracTickets for help on using tickets.