Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#2340 closed change (fixed)

Don't generate pages if less than 30% have been translated

Reported by: trev Assignee: trev
Priority: P3 Milestone:
Module: Sitescripts Keywords:
Cc: Blocked By:
Blocking: #2035 Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: yes
Review URL(s):

http://codereview.adblockplus.org/5242593268989952/

Description

Background

Currently, we have pages like https://beta.adblockplus.org/he/about where only one string has been translated. This makes a bad impression and isn't helpful at all.

What to change

Change generation of static pages to write out pages only if at least 30% of the strings have been translated.

Change History (5)

comment:1 Changed 5 years ago by trev

  • Blocking 2035 added

comment:2 Changed 5 years ago by trev

  • Owner set to trev

comment:3 Changed 5 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 5 years ago by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 5 years ago by Ross

  • Verified working set

Implemented and working.

Tested by:
Creating a test CMS content project containing an index file and one localised page with 20 translatable strings. The localised page is generated if 6 or more (30%) strings are in the matching locale file and is not generated with 5 or less.

Tested with:
cms / r43

Note: See TracTickets for help on using tickets.