Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#2346 closed change (fixed)

[Adblocking settings] Add the adblocking languages category

Reported by: fhd Assignee: rjeschke
Priority: P2 Milestone: Adblock-Browser-for-Android-beta-1.0.0.2015052021
Module: Adblock-Browser-for-Android Keywords: 2015q2
Cc: Blocked By:
Blocking: #2345 Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

http://codereview.adblockplus.org/6405940995686400/

Description (last modified by philll)

Background

See #2345.

What to change

Add a new settings category where the user can add/remove adblocking languages, as in the mockup.

These languages are actually not languages, but language-specific filter subscriptions - those are the subscriptions from subscriptions2.xml that have the prefixes attribute. The text from the specialization attribute should be shown as the language's name (e.g. German in the mockup), and the text from the title attribute below that (e.g. EasyList in the mockup).

The category should have two sections:

Active for websites in ..., which should show all the language-specific filter subscriptions that are currently enabled.

Other languages, which should show all the language-specific filter subscriptions that are not added or disabled.

When the user toggles the switch next to a subscription, the subscription should move to the other section. Activating a subscription should add (or, if already present, enable) it, deactivating a subscription should remove it.

Attachments (1)

adblock browser v12 - 4 adblocking.png (89.1 KB) - added by fhd 5 years ago.
Adblocking settings mock up

Download all attachments as: .zip

Change History (17)

comment:1 Changed 5 years ago by fhd

  • Owner set to rjeschke

comment:2 Changed 5 years ago by fhd

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 5 years ago by fhd

  • Ready unset

Removing ready - this is not specified properly.

Changed 5 years ago by fhd

Adblocking settings mock up

comment:4 Changed 5 years ago by fhd

  • Description modified (diff)
  • Ready set

Specified things properly (I guess), setting to Ready again.

Last edited 5 years ago by fhd (previous) (diff)

comment:5 Changed 5 years ago by philll

  • Ready unset

Which lists and respective languages shall be shown in general? Please provide that list explicitly with links to the respective lists. Not showing the list's names at all might confuse more advanced users.

The language names of active choices in the mockup are lower case, which is wrong.

What are "spezialisation texts from subscriptions.xml" and where to find them?

What does "enable the subscription for that language" mean?

The summary "Adblocking languages" is just a caption if at all, but not a summary. Also, as mentioned before, not having any hint on the target location of a change in the summary maked it incredibly hard to use lists of issues in Trac.

Last edited 5 years ago by philll (previous) (diff)

comment:6 Changed 5 years ago by fhd

  • Description modified (diff)
  • Summary changed from [Adblocking settings] Adblocking languages to [Adblocking settings] Add the adblocking languages category

The texts are all taken from subscriptions.xml - how that works is so obvious to me that I didn't even think about explaining it, but you're right, has to be explained. Is that clear now?

comment:7 Changed 5 years ago by fhd

  • Description modified (diff)

The patch under review is actually already showing the subscription names - all the better.

comment:8 Changed 5 years ago by fhd

  • Description modified (diff)

Trying to reduce the confusion between languages/subscriptions a bit.

comment:9 Changed 5 years ago by fhd

  • Ready set

comment:10 Changed 5 years ago by rjeschke

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:11 Changed 5 years ago by fhd

  • Milestone set to Flux-next

comment:12 Changed 5 years ago by fhd

  • Keywords 2015q2 added

comment:13 Changed 5 years ago by fhd

  • Sensitive unset

comment:15 Changed 4 years ago by philll

  • Platform changed from Android to Adblock Browser for Android

See #2673

comment:16 Changed 4 years ago by philll

  • Description modified (diff)
  • Tester set to Unknown
Note: See TracTickets for help on using tickets.