Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#2351 closed change (fixed)

Improve menu item for whitelisting the current site

Reported by: fhd Assignee: fhd
Priority: P2 Milestone: Adblock-Browser-for-Android-beta-1.0.0.2015052021
Module: Adblock-Browser-for-Android Keywords: 2015q2
Cc: Blocked By:
Blocking: Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5365916275572736

Description (last modified by fhd)

Background

The menu item for whitelisting the current site that's added by ABP has two issues:

  1. It shows up at the bottom of the list - on a typical smartphone screen that means the user has to scroll to see it. It is in fact so hard to notice that I was pretty sure it wasn't working...
  1. It says: "ABP: Disable on [domain]". We've never talking about Adblock Plus (let alone its abbreviation) in Adblock Browser.

What to change

The menu item should:

  1. Be a checkbox item, just like "Request Desktop Site".
  2. Have the label "Block Ads on this Site".
  3. Show up right before "Request Desktop Site".
  4. Never disappear, but get disabled and unchecked on local sites instead.

Change History (13)

comment:1 Changed 5 years ago by fhd

  • Keywords 2015q2 added

comment:2 Changed 5 years ago by rjeschke

Works for me, are you sure we need to fix something here? (Well, maybe it's in the wrong menu?)

https://www.dropbox.com/s/jzfcqvhxql1ficy/disable_on_heise.png

Last edited 5 years ago by rjeschke (previous) (diff)

comment:3 Changed 5 years ago by fhd

Yes, it actually does work. However I see two problems with this:

  1. It says "ABP: Disable on $domain" - how is the user supposed to know what "ABP" is? We don't mention that anywhere.
  2. For me at least, the item is never visible without scrolling, even when there would be sufficient space for the menu to grow a little. That's probably why I thought it's not there.

comment:4 Changed 4 years ago by fhd

  • Description modified (diff)
  • Summary changed from Menu entry to whitelist the current site is not showing up to Better menu item for whitelisting the current site
  • Type changed from defect to change

I believe we need to do something about this - turned this into a change and updated summary/description accordingly.

comment:5 Changed 4 years ago by fhd

  • Owner set to fhd

comment:6 Changed 4 years ago by fhd

  • Description modified (diff)
  • Summary changed from Better menu item for whitelisting the current site to Improve menu item for whitelisting the current site

comment:7 Changed 4 years ago by fhd

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:8 Changed 4 years ago by fhd

  • Milestone set to Flux-next

comment:9 Changed 4 years ago by fhd

  • Description modified (diff)

comment:10 Changed 4 years ago by fhd

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:11 Changed 4 years ago by fhd

  • Sensitive unset

comment:13 Changed 4 years ago by philll

  • Platform changed from Android to Adblock Browser for Android

See #2673

Note: See TracTickets for help on using tickets.