Opened 5 years ago

Closed 4 years ago

#2357 closed change (fixed)

Implement "Add predefined list" dialog

Reported by: greiner Assignee: greiner
Priority: P2 Milestone:
Module: User-Interface Keywords:
Cc: Blocked By: #1524
Blocking: #2355, #2410 Platform: Unknown
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29321417/

Description

Background

Clicking on "abp:subscribe" links opens the options page and asks for confirmation from the user. This requires a more restricted version of the "Add further blocking list" dialog to be added.

What to change

  • Implement separate dialog based on design mockup similar to existing "Add further blocking list" dialog
  • The dialog should be created based on the provided filter list title and URL
  • Don't show the filter list title if it's not specified
  • Clicking on the "Yes, use this filter list" button should add the filter list
  • Click on "cancel" should simply close the dialog

Change History (5)

comment:1 Changed 5 years ago by greiner

  • Blocked By 1524 added

comment:2 Changed 4 years ago by greiner

  • Blocking 2410 added

comment:3 Changed 4 years ago by greiner

  • Owner set to greiner
  • Tester set to Unknown

comment:4 Changed 4 years ago by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 4 years ago by greiner

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.