Opened on 04/20/2015 at 03:41:59 PM

Closed on 01/24/2017 at 04:01:10 PM

#2359 closed change (fixed)

Finish design of General tab of new options page

Reported by: greiner Assignee: greiner
Priority: P2 Milestone:
Module: User-Interface Keywords: 2016q1
Cc: sebastian Blocked By: #1524
Blocking: #2355, #2773 Platform: Unknown
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by sebastian)


In #1526 we were creating the very first version of the General tab. Not all requested design changes were applied, however. Therefore we need to make the following changes to finish the design.

What to change

  • Restrict length of filter list titles using the following styles:
    overflow: hidden;
    text-overflow: ellipsis;
    white-space: nowrap;
  • Remove custom scrollbar styles which were applied using WebKit-specific CSS selectors
  • Make sure that all fonts, proportions and colors match the ones mentioned in the styles guides linked in #1526 including:
    • Add border-radius to table list elements
    • Make tab content always be at least as tall as the page
    • Remove bottom border from tab content
    • Specify height for each of the quadrants similar the same way it's implemented for further blocking options quadrant
    • Correct width, height and background position of icons
  • Update title texts
    • Change "Adblocking for websites in..." to "Ad blocking for websites in…"
    • Change "Acceptable ads" to "Acceptable Ads"
  • Other minor changes related to general tab
    • Expose the full filter list title using standard tooltips by setting the "title" attribute on the element containing the filter list title

Attachments (0)

Change History (15)

comment:1 Changed on 04/23/2015 at 02:04:02 PM by greiner

  • Blocked By 1524 added

comment:2 Changed on 06/30/2015 at 09:59:10 AM by greiner

  • Owner set to greiner
  • Tester set to Unknown

comment:3 Changed on 07/02/2015 at 09:52:02 AM by greiner

  • Description modified (diff)

comment:4 Changed on 07/03/2015 at 09:06:25 AM by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed on 07/13/2015 at 11:35:35 AM by greiner

  • Status changed from reviewing to reopened

comment:6 Changed on 11/04/2015 at 11:40:35 AM by greiner

  • Description modified (diff)

comment:7 Changed on 01/06/2016 at 02:36:33 PM by greiner

  • Review URL(s) modified (diff)

comment:8 Changed on 01/06/2016 at 03:50:13 PM by greiner

  • Description modified (diff)

Added title texts changes

comment:9 Changed on 01/06/2016 at 05:47:52 PM by greiner

  • Status changed from reopened to reviewing

comment:10 Changed on 01/07/2016 at 07:19:05 PM by greiner

  • Blocking 2773 added

comment:11 Changed on 01/15/2016 at 12:08:35 PM by sebastian

  • Cc sebastian added
  • Description modified (diff)

comment:12 Changed on 01/27/2016 at 03:01:18 PM by greiner

comment:13 Changed on 01/27/2016 at 04:07:30 PM by sebastian

  • Keywords 2016q1 added

It seems this issue should also be fixed before moving on with translations and integration in Adblock Plus for Chrome/Safari (mostly due to the string changes). Therefore adding the roadmap keyword.

Last edited on 01/27/2016 at 04:08:47 PM by sebastian

comment:14 Changed on 12/28/2016 at 09:26:19 AM by DylanMarkLeo7

[Comment removed due to spam]

Last edited on 01/24/2017 at 03:59:16 PM by greiner

comment:15 Changed on 01/24/2017 at 04:01:10 PM by greiner

  • Resolution set to fixed
  • Status changed from reviewing to closed

Closing this ticket because the remaining changes refer to an outdated design.

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from greiner.
Note: See TracTickets for help on using tickets.