Opened 5 years ago

Closed 3 years ago

#2359 closed change (fixed)

Finish design of General tab of new options page

Reported by: greiner Assignee: greiner
Priority: P2 Milestone:
Module: User-Interface Keywords: 2016q1
Cc: sebastian Blocked By: #1524
Blocking: #2355, #2773 Platform: Unknown
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29321240/
https://codereview.adblockplus.org/29333262/

Description (last modified by sebastian)

Background

In #1526 we were creating the very first version of the General tab. Not all requested design changes were applied, however. Therefore we need to make the following changes to finish the design.

What to change

  • Restrict length of filter list titles using the following styles:
    overflow: hidden;
    text-overflow: ellipsis;
    white-space: nowrap;
    
  • Remove custom scrollbar styles which were applied using WebKit-specific CSS selectors
  • Make sure that all fonts, proportions and colors match the ones mentioned in the styles guides linked in #1526 including:
    • Add border-radius to table list elements
    • Make tab content always be at least as tall as the page
    • Remove bottom border from tab content
    • Specify height for each of the quadrants similar the same way it's implemented for further blocking options quadrant
    • Correct width, height and background position of icons
  • Update title texts
    • Change "Adblocking for websites in..." to "Ad blocking for websites in…"
    • Change "Acceptable ads" to "Acceptable Ads"
  • Other minor changes related to general tab
    • Expose the full filter list title using standard tooltips by setting the "title" attribute on the element containing the filter list title

Change History (15)

comment:1 Changed 5 years ago by greiner

  • Blocked By 1524 added

comment:2 Changed 4 years ago by greiner

  • Owner set to greiner
  • Tester set to Unknown

comment:3 Changed 4 years ago by greiner

  • Description modified (diff)

comment:4 Changed 4 years ago by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 4 years ago by greiner

  • Status changed from reviewing to reopened

comment:6 Changed 4 years ago by greiner

  • Description modified (diff)

comment:7 Changed 4 years ago by greiner

  • Review URL(s) modified (diff)

comment:8 Changed 4 years ago by greiner

  • Description modified (diff)

Added title texts changes

comment:9 Changed 4 years ago by greiner

  • Status changed from reopened to reviewing

comment:10 Changed 4 years ago by greiner

  • Blocking 2773 added

comment:11 Changed 4 years ago by sebastian

  • Cc sebastian added
  • Description modified (diff)

comment:12 Changed 4 years ago by greiner

comment:13 Changed 4 years ago by sebastian

  • Keywords 2016q1 added

It seems this issue should also be fixed before moving on with translations and integration in Adblock Plus for Chrome/Safari (mostly due to the string changes). Therefore adding the roadmap keyword.

Last edited 4 years ago by sebastian (previous) (diff)

comment:14 Changed 3 years ago by DylanMarkLeo7

[Comment removed due to spam]

Last edited 3 years ago by greiner (previous) (diff)

comment:15 Changed 3 years ago by greiner

  • Resolution set to fixed
  • Status changed from reviewing to closed

Closing this ticket because the remaining changes refer to an outdated design.

Note: See TracTickets for help on using tickets.