Opened 6 years ago

Closed 6 years ago

#236 closed defect (fixed)

Development build changelogs cannot deal with Unicode

Reported by: trev Assignee: trev
Priority: P4 Milestone:
Module: Infrastructure Keywords: goodfirstbug
Cc: Blocked By:
Blocking: Platform:
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

​http://codereview.adblockplus.org/5658647514316800/

Description

How to reproduce

Open ​https://downloads.adblockplus.org/devbuilds/adblockplusandroid/adblockplusandroid-1.2.0.317.changelog.xhtml

Observed behaviour

For the top commit it lists "Ren? Jeschke" as author.

Expected behaviour

Author's name should be displayed correctly as "René Jeschke," that's how it appears on ​https://hg.adblockplus.org/adblockplusandroid/.

Change History (5)

comment:1 Changed 6 years ago by trev

sitescripts.extensions.bin.createNightlies module runs hg log to produce the changelogs, it probably needs to set LC_ALL=en_US.UTF-8 or something like that.

comment:2 Changed 6 years ago by trev

  • Keywords goodfirstbug added

comment:3 Changed 6 years ago by trev

  • Owner set to trev

comment:4 Changed 6 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 6 years ago by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

Fixed: ​https://hg.adblockplus.org/sitescripts/rev/a55786c6887f

Note: See TracTickets for help on using tickets.