Opened 3 years ago

Closed 3 years ago

#2367 closed change (fixed)

[Move notification display logic to Core] Use a notification show listener in Firefox

Reported by: fhd Assignee: fhd
Priority: P2 Milestone: Adblock-Plus-2.6.10-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords: 2015q2
Cc: Blocked By: #2420
Blocking: #2366 Platform: Firefox
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5256408131960832/ (Same as for #2420, tackled them together)

Description (last modified by fhd)

Background

See #2366.

What to change

Instead of showing notifications three minutes after startup, register a notification show listener (provided by #2420) and show notifications only when that one is triggered.

Change History (11)

comment:1 Changed 3 years ago by fhd

  • Blocking 2366 added

comment:2 Changed 3 years ago by fhd

  • Keywords 2015q2 added

comment:3 Changed 3 years ago by fhd

  • Description modified (diff)

comment:4 Changed 3 years ago by fhd

  • Blocked By 2386 added

comment:5 Changed 3 years ago by fhd

  • Description modified (diff)

comment:6 Changed 3 years ago by fhd

  • Blocked By 2420 added; 2386 removed
  • Description modified (diff)
  • Summary changed from [Show notifications after downloading] in Firefox to [Move notification display logic to Core] Use notification show listener in Firefox

comment:7 Changed 3 years ago by fhd

  • Summary changed from [Move notification display logic to Core] Use notification show listener in Firefox to [Move notification display logic to Core] Use a notification show listener in Firefox

comment:8 Changed 3 years ago by philll

  • Platform changed from Firefox/Firefox Mobile to Firefox

Made Firefox and Firefox mobile available as seperate platforms.

comment:9 Changed 3 years ago by fhd

  • Owner set to fhd

comment:10 Changed 3 years ago by fhd

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:11 Changed 3 years ago by fhd

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

Fixed by #2420.

Note: See TracTickets for help on using tickets.