Changes between Version 10 and Version 13 of Ticket #2368


Ignore:
Timestamp:
06/18/2015 12:35:04 PM (4 years ago)
Author:
sebastian
Comment:

Sorry, I overlooked two nits while reviewing this change:

  • showNotification() is always called with an object. Therefore the check for !notification is redundant now.
  • Redundant wrapper function: showNotification can be passed directly to NotificationStorage.addShowListener.

Here comes a follow up patch.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #2368

    • Property Status changed from reviewing to closed
    • Property Resolution changed from to fixed
    • Property Milestone changed from to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Ticket #2368 – Review URL(s)

    v10 v13  
    1 http://codereview.adblockplus.org/5733084272001024/ 
     1https://codereview.adblockplus.org/5733084272001024/ 
     2https://codereview.adblockplus.org/29317071