Opened 5 years ago

Last modified 5 years ago

#2368 closed change

[Move notification display logic to Core] Use a notification show listener in Chrome/Opera/Safari — at Version 7

Reported by: fhd Assignee:
Priority: P2 Milestone: Adblock-Plus-1.9.1-for-Chrome-Opera-Safari
Module: Platform Keywords: 2015q2
Cc: Blocked By: #2420
Blocking: #2366 Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

https://codereview.adblockplus.org/5733084272001024/
https://codereview.adblockplus.org/29317071

Description (last modified by fhd)

Background

See #2366.

What to change

Instead of showing notifications three minutes after startup, register a notification show listener (provided by #2420) and show notifications only when that one is triggered.

Change History (7)

comment:1 Changed 5 years ago by fhd

  • Blocking 2366 added

comment:2 Changed 5 years ago by fhd

  • Keywords 2015q2 added

comment:3 Changed 5 years ago by fhd

  • Description modified (diff)

comment:4 Changed 5 years ago by fhd

  • Description modified (diff)

comment:5 Changed 5 years ago by fhd

  • Blocked By 2386 added

comment:6 Changed 5 years ago by fhd

  • Description modified (diff)

comment:7 Changed 5 years ago by fhd

  • Blocked By 2420 added; 2386 removed
  • Description modified (diff)
  • Summary changed from [Show notifications after downloading] in Chrome/Opera/Safari to [Move notification display logic to Core] Use a notification show listener in Chrome/Opera/Safari
Note: See TracTickets for help on using tickets.