Opened 5 years ago

Closed 2 years ago

#2369 closed change (fixed)

[Move notification display logic to Core] Use a notification show listener in Internet Explorer

Reported by: fhd Assignee:
Priority: P3 Milestone:
Module: Adblock-Plus-for-Internet-Explorer Keywords:
Cc: Blocked By: #2387
Blocking: #2366 Platform: Internet Explorer
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by fhd)

Background

See #2366.

What to change

Instead of showing notifications three minutes after startup, register a notification show listener (provided by #2387) and show notifications only when that one is triggered.

Change History (6)

comment:1 Changed 5 years ago by fhd

  • Blocking 2366 added
  • Priority changed from P2 to P3

comment:2 Changed 5 years ago by fhd

  • Description modified (diff)

comment:3 Changed 5 years ago by fhd

  • Blocked By 2387 added

comment:4 Changed 5 years ago by fhd

  • Description modified (diff)

comment:5 Changed 5 years ago by fhd

  • Description modified (diff)
  • Summary changed from [Show notifications after downloading] in Internet Explorer to [Move notification display logic to Core] Use a notification show listener in Internet Explorer

comment:6 Changed 2 years ago by sergz

  • Resolution set to fixed
  • Status changed from new to closed
  • Tester set to Unknown

It's already implemented this way (was fixed during the codereview https://codereview.adblockplus.org/6505394822184960/).

Note: See TracTickets for help on using tickets.