Opened 5 years ago

Closed 2 years ago

#2373 closed change (fixed)

Add/change a sentence on filters page regarding EHH removing tag names by default

Reported by: arthur Assignee: ire
Priority: P3 Milestone:
Module: Websites Keywords: goodfirstbug
Cc: trev, saroyanm Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29501555/

Description (last modified by trev)

Background

On https://adblockplus.org/en/filters#elemhide examples are shown with e. g. ##div#sponsorad and ##div.textad. Element Hiding Helper removes the tag names (-> ###sponsorad and ##.textad) because ABP processes them faster.

What to change

Change the text as to not suggest using tag names in selectors - this is an artifact from the simplified syntax which we no longer support.

The first advertisement above is contained inside an element with class attribute "textad". The following rule will hide exactly any such element: ##.textad. Here ## marks an element hiding rule while the rest is a selector identifying the elements that need to be hidden. You can hide elements by their id attribute similarly, ###sponsorad will hide the second advertisement. And you can hide elements by element name only, e.g. ##textad for the third advertisement.

We should also remove tag names (and *) from the example selectors in the following sections. And to the first paragraph under "Advanced selectors" we should add:

Please keep in mind that browsers are slower to process these selectors than selectors based on class or id attribute only.

Change History (9)

comment:1 Changed 5 years ago by saroyanm

  • Cc trev added

IMO it's better to use second option, because it makes more sense I'm not sure why it was specified like that initially.
Wladimir can you please let me know if there was a reason of using rule like ##*#sponsorad in the documentation ? I think the second suggestion is more reasonable and we can go with the second one.

I don't think this ticket has anything to do with EHH.

comment:2 Changed 5 years ago by saroyanm

  • Cc saroyanm added

comment:3 Changed 3 years ago by trev

  • Description modified (diff)
  • Tester set to Unknown

comment:4 Changed 3 years ago by saroyanm

  • Priority changed from Unknown to P3
  • Ready set

This looks to be ready.

comment:5 Changed 3 years ago by juliandoucette

  • Keywords goodfirstbug added

comment:6 Changed 2 years ago by ire

  • Owner set to ire

comment:7 Changed 2 years ago by ire

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:9 Changed 2 years ago by ire

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.