Opened 4 years ago

Closed 3 years ago

#2374 closed change (fixed)

Implement "Tweaks" section in new options page

Reported by: greiner Assignee: greiner
Priority: P2 Milestone:
Module: User-Interface Keywords: 2016q1
Cc: sebastian, kzar Blocked By: #1524, #2356
Blocking: #2372, #3800 Platform: Unknown
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29337729/

Description (last modified by sebastian)

Background

In the current version of the options page we expose some general settings in the General tab. Those settings should be exposed under "Tweaks".

What to change

  • Implement the "Show right-click menu Block Element" setting as a checkbox in the Tweaks section (as outlined in the provided design mockup)
    • Clicking on the checkbox should toggle the shouldShowBlockElementMenu preference like it does in the current version of the options page
  • Implement the "Show useful notifications" setting as a checkbox in the Tweaks section (see #2195)
    • This setting should be hidden by default and only be shown if Prefs.notifications_showui is set to true
    • Clicking on the checkbox should toggle the "*" entry in Prefs.notifications_ignoredcategories
  • Checkboxes should be kept up-to-date using prefs.listen
  • Add prefs.toggle message type to messageResponder.js
  • Add an option to enable experimental content blocker mode on Safari as specified in #3687.
  • Add an option to remove the devtools panel as specified in #3796.

Change History (13)

comment:1 Changed 4 years ago by greiner

  • Blocked By 1524 added

comment:2 Changed 4 years ago by greiner

  • Blocked By 2356 added

comment:3 Changed 3 years ago by mario

  • Keywords 2015q4 added
  • Tester set to Unknown

comment:4 Changed 3 years ago by greiner

  • Description modified (diff)

Updated ticket to reflect changes to existing options page in #2195.

comment:5 Changed 3 years ago by greiner

  • Description modified (diff)
  • Ready set

The tooltips for individual settings will be added later on.

comment:6 Changed 3 years ago by greiner

  • Owner set to greiner

comment:7 Changed 3 years ago by sebastian

  • Cc sebastian added
  • Keywords 2016q1 added; 2015q4 removed

comment:8 Changed 3 years ago by sebastian

  • Cc kzar added
  • Description modified (diff)

comment:9 Changed 3 years ago by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:10 Changed 3 years ago by sebastian

  • Description modified (diff)

comment:11 Changed 3 years ago by sebastian

  • Blocking 3800 added

comment:12 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
https://hg.adblockplus.org/adblockplusui/rev/0ccb42e76177

comment:13 Changed 3 years ago by greiner

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.