Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#2375 closed change (fixed)

Implement "Blocking lists" section in new options page

Reported by: greiner Assignee: saroyanm
Priority: P2 Milestone:
Module: User-Interface Keywords: 2016q1
Cc: sven, lisabielik, sebastian Blocked By: #1524
Blocking: #2372, #3884 Platform: Unknown
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29333819/

Description (last modified by saroyanm)

Background

We want to expose all filter list managing functionality in the "Blocking lists" section since we only have a limit set of features on the General tab. While custom filters are closely related to this ticket, they are a separate issue and therefore being covered in separate tickets.

What to change

  • Implement tabbed layout to switch between filter lists and custom filters
  • Update filter lists table according to style guide (find calendar and time icons attached).
  • Create drop-down for blocking lists based on this style-guide, with menu items "update now", "website", "source" and "delete". Every item has an additional icon: update now, website, source, delete
  • Show a list of all installed filter lists in a table layout sorted by title with the following values:
    • checkbox: Subscription.disabled
    • Name: Subscription.title
    • Last update: Show the date and time using Subscription.lastDownload in "yyyy-mm-dd mm:ss" format or show error messages as defined in current version of options page according to subscription.downloadStatus (one notable exception is the "Own blocking list" entry where it contains a link to the "Edit or create own blocking list" tab)
  • The data in the table should be kept up-to-date using subscriptions.listen
  • Next to the name of each filter list (except for the "Own blocking list" entry) should be an arrow for opening up a context menu (see design mockup) containing the following items:
    • update now: update the filter list
    • website: open the URL Subscription.homepage in a new tab; should only be shown if Subscription.homepage is specified
    • source: open the URL Subscription.url in a new tab
    • delete: remove the filter list
  • The last item on the list should be a statically added filter list with the name "Own blocking list"
  • The "add other blocking list" link should open up the "Add other blocking list" dialog
  • The "update all blocking lists" link should have the same behavior as the "Update now" button in the current version of the options page
  • Implement subscriptions.update message type in messageResponder.js (see interface definition)

Attachments (9)

options_page_103-1.jpg (2.1 MB) - added by saroyanm 4 years ago.
Filter lists style guide
date-pngout.png (132 bytes) - added by saroyanm 4 years ago.
Date icon
time-pngout.png (437 bytes) - added by saroyanm 4 years ago.
Time Icon
options_page_95_dropdown_distances.jpg (408.3 KB) - added by saroyanm 4 years ago.
Tooltip style guide
delete_v1_pngout.png (267 bytes) - added by saroyanm 4 years ago.
Delete icon
source_v1_pngout.png (423 bytes) - added by saroyanm 4 years ago.
Link icon
website_v1_pngout.png (152 bytes) - added by saroyanm 4 years ago.
Website icon
refresh_v1_pngout.png (227 bytes) - added by saroyanm 4 years ago.
Refresh icon
arrowdown.png (18.0 KB) - added by sven 4 years ago.

Download all attachments as: .zip

Change History (31)

comment:1 Changed 5 years ago by greiner

  • Blocked By 1524 added

Changed 4 years ago by saroyanm

Filter lists style guide

Changed 4 years ago by saroyanm

Date icon

Changed 4 years ago by saroyanm

Time Icon

comment:2 Changed 4 years ago by saroyanm

  • Description modified (diff)
  • Tester set to Unknown

Changed 4 years ago by saroyanm

Tooltip style guide

Changed 4 years ago by saroyanm

Delete icon

Changed 4 years ago by saroyanm

Link icon

Changed 4 years ago by saroyanm

Website icon

Changed 4 years ago by saroyanm

Refresh icon

comment:3 Changed 4 years ago by saroyanm

  • Description modified (diff)

Moved some bullet points filter list related from #2377.

comment:4 Changed 4 years ago by saroyanm

  • Owner set to saroyanm

comment:5 Changed 4 years ago by greiner

  • Description modified (diff)
  • Ready set

comment:6 Changed 4 years ago by saroyanm

  • Cc sven added

Description: description taken from subscriptions.xml and empty if there's no description associated with the filter list

According to the new style guide there is no description column, so what is the decision about description column should it still be implemented ?

comment:7 follow-up: Changed 4 years ago by sven

According to the new style guide there is no description column, so what is the decision about description column should it still be implemented ?

No.

comment:8 Changed 4 years ago by saroyanm

  • Description modified (diff)

Updated the description accordingly,
still I'm not sure what is the time column is used for ?

Last update: Subscription.downloadStatus or error messages as defined in current version of options page

Should error message displayed in blocking list table's cell ?

comment:9 in reply to: ↑ 7 Changed 4 years ago by greiner

Replying to sven:

According to the new style guide there is no description column, so what is the decision about description column should it still be implemented ?

No.

We might end up implementing the short description anyway since we do also need to implement long descriptions for the tooltips (see #2668). So while this is the design we should go with right now, it will probably not make it into the first release.

comment:10 Changed 4 years ago by mario

  • Keywords 2015q4 added

comment:11 Changed 4 years ago by saroyanm

Do we have the Icon for the icon/button that will open the drop-down for blocking lists ?

Changed 4 years ago by sven

comment:12 Changed 4 years ago by saroyanm

  • Description modified (diff)

comment:13 Changed 4 years ago by saroyanm

Updated the description, to make it more consistent with current implementation.

comment:14 Changed 4 years ago by saroyanm

  • Description modified (diff)

comment:15 Changed 4 years ago by saroyanm

  • Description modified (diff)

Added, the action for "delete" item in context menu.

comment:16 Changed 4 years ago by saroyanm

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:17 follow-up: Changed 4 years ago by saroyanm

  • Cc lisabielik added

Lisa can you please help me with several texts in this ticket, while the style guides are little bit old already would be nice to align with you before pushing changes to live:
We have two strings which probably needs to be changed as part of current ticket, which are "Own blocking list" and "edit your blocking list", should I use "Own filter list" and "edit your filter list" instead ?

comment:18 in reply to: ↑ 17 ; follow-up: Changed 4 years ago by lisabielik

Replying to saroyanm:

Lisa can you please help me with several texts in this ticket, while the style guides are little bit old already would be nice to align with you before pushing changes to live:
We have two strings which probably needs to be changed as part of current ticket, which are "Own blocking list" and "edit your blocking list", should I use "Own filter list" and "edit your filter list" instead ?

All instances of "blocking list" should be changed to "filter list." Please note that "filter list" should always be two words (filter list NOT filterlist).

Also, the following need changed if they haven't already been addressed:

options_page_95_dropdown_distances.jpg:

  • Show right click menu - Show right-click menu
  • Adblocking - Ad blocking

I would like to review the text for the entire Options page (all tabs) before it gets pushed. Can you send me that information so it can be reviewed? Thanks!

comment:19 in reply to: ↑ 18 Changed 4 years ago by saroyanm

Replying to lisabielik:

Replying to saroyanm:

Lisa can you please help me with several texts in this ticket, while the style guides are little bit old already would be nice to align with you before pushing changes to live:
We have two strings which probably needs to be changed as part of current ticket, which are "Own blocking list" and "edit your blocking list", should I use "Own filter list" and "edit your filter list" instead ?

All instances of "blocking list" should be changed to "filter list." Please note that "filter list" should always be two words (filter list NOT filterlist).

Thanks

Also, the following need changed if they haven't already been addressed:

options_page_95_dropdown_distances.jpg:

  • Show right click menu - Show right-click menu

We have different wording, currently it's Show Block Element right-click menu item, the design mockup you refer to is for the context menu element (other texts can be outdated), I'm sure that we will revisit the wording and probably will update all old strings that needs to be changed I hope soon.

  • Adblocking - Ad blocking

We currently have two columns for name and Last update as specified in the ticket.

I would like to review the text for the entire Options page (all tabs) before it gets pushed. Can you send me that information so it can be reviewed? Thanks!

comment:20 Changed 4 years ago by sebastian

  • Cc sebastian added
  • Keywords 2016q1 added; 2015q4 removed

comment:21 Changed 4 years ago by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:22 Changed 4 years ago by saroyanm

  • Blocking 3884 added
Note: See TracTickets for help on using tickets.