Opened 4 years ago

Closed 4 years ago

#2381 closed change (fixed)

Implement share overlay in new options page

Reported by: greiner Assignee: greiner
Priority: P2 Milestone:
Module: User-Interface Keywords:
Cc: Blocked By: #1524
Blocking: #2380 Platform: Unknown
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29321336/

Description (last modified by greiner)

Background

In the first-run page we show an overlay containing different sharing options if someone clicks on one of the share buttons. We also want to have this overlay in the new options page.

What to change

  • Check if one of the resources required for showing the social media buttons in the overlay is blocked (same check we already use in the first-run page)
  • If one or more of the resources are blocked: Hide the share button in the sidebar
  • If none of the resources is blocked: Attach a click-listener to the share button in the sidebar which opens the overlay (same way we do in the first-run page)
  • The share button should always be hidden for users with a Chinese locale

Notes for dependency update

This change moves the code that's shared between first-run page and options page into common.js and skin/common.css. Therefore these two files are required for either of those pages to work properly.

Change History (5)

comment:1 Changed 4 years ago by greiner

  • Blocked By 1524 added

comment:2 Changed 4 years ago by greiner

  • Owner set to greiner
  • Tester set to Unknown

comment:3 Changed 4 years ago by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 4 years ago by greiner

  • Description modified (diff)

comment:5 Changed 4 years ago by greiner

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.