Opened 5 years ago

Closed 4 years ago

#2392 closed change (fixed)

Create a container for CSS property filters

Reported by: trev Assignee: greiner
Priority: P2 Milestone:
Module: Core Keywords:
Cc: Blocked By: #2390
Blocking: #2389, #2393, #2396 Platform: Unknown
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29324599/

Description

Background

The new filter class introduced in #2390 needs its own container with appropriate API.

What to change

Add cssRules.js module defining a CSSRules singleton. It should have the following methods:

  • add(filter)
  • remove(filter)
  • clear()
  • getRulesForDomain()

It should use appropriate data structures to make sure that getRulesForDomain() is efficient.

Change History (8)

comment:1 Changed 5 years ago by trev

  • Blocking 2393 added

comment:2 Changed 5 years ago by trev

  • Blocked By 2390 added

comment:3 Changed 5 years ago by trev

  • Blocking 2396 added

comment:4 Changed 5 years ago by greiner

  • Blocked By 235 added

I'd really like to finish ticket #235 before starting with this one to avoid discussing and working on the same approach in two different places since those two changes implement similar functionality.

comment:5 Changed 4 years ago by greiner

  • Owner set to greiner
  • Tester set to Unknown

comment:6 Changed 4 years ago by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:7 Changed 4 years ago by greiner

  • Blocked By 235 removed

comment:8 Changed 4 years ago by greiner

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.