Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#2394 closed change (fixed)

Update unit tests for CSS property filters

Reported by: trev Assignee: greiner
Priority: P2 Milestone:
Module: Extensions-for-Adblock-Plus Keywords:
Cc: Blocked By:
Blocking: #2389 Platform: Unknown
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29324604/

Description

Background

#2390, #2392, #2393 introduce significant changes to the filter handling. These need to be tested.

What to change

Update the following unit tests to consider CSS property filters:

  • domainRestrictions.js
  • filterClasses.js
  • filterListener.js
  • filterStorage_readwrite.js

Change History (5)

comment:1 Changed 5 years ago by trev

  • Component changed from Extensions-for-Adblock-Plus to Adblock-Plus-for-Firefox

comment:2 Changed 5 years ago by greiner

  • Owner set to greiner

comment:3 Changed 4 years ago by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing
  • Tester set to Unknown

comment:4 Changed 4 years ago by greiner

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 4 years ago by trev

  • Component changed from Adblock-Plus-for-Firefox to Extensions-for-Adblock-Plus
Note: See TracTickets for help on using tickets.