Changes between Initial Version and Version 1 of Ticket #2395, comment 6


Ignore:
Timestamp:
04/22/2015 01:45:14 PM (4 years ago)
Author:
sebastian
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #2395, comment 6

    initial v1  
    11`updateStylesheet()` sends a message to the background page retriving the selectors for (regular) element hiding filters and applies them. Not quite what we need here. Sure, changes can be done to `include.preload.js` to reuse the functionality injecting the styles, from a different content script. But then we would still have two calls to the background page, one for regular element hiding filters, and the one done by the content script here for CSS property filters. Things could be simplified and would be more efficient if we have the content script here handle regular element hiding as well on Chrome, sending only one message to the background page. 
    22 
    3 How would the injection be different on Firefox, if it's performed by the content script as well, rather then with a user stylesheet? 
     3And we could potentially reuse the code for injecting styles from Chrome for Firefox, or how would it be different there, if it's performed by the content script as well, rather then with a user stylesheet?