Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#2399 closed change (rejected)

Implement a content script mechanism

Reported by: trev Assignee:
Priority: P2 Milestone:
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: #2398 Platform: Unknown
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Background

CSS property filters are going to be implemented as a content script, there is currently no mechanism to execute them in Firefox.

What to change

Add a lib/contentScripts.js module exposing a function injectScript(contentWindow, scriptUrl). The injected content script should have direct access to the page's DOM but not to its JavaScript variables. It should also have access to ext.backgroundPage.sendMessage() and ext.onMessage() API, similarly to the first-run page.

Change History (4)

comment:1 Changed 5 years ago by trev

  • Blocking 2398 added; 2388 removed

comment:2 Changed 5 years ago by trev

  • Blocking 2401 added

comment:3 Changed 4 years ago by trev

  • Resolution set to rejected
  • Status changed from new to closed
  • Tester set to Unknown

In the end we decided against "proper" content scripts. Instead, we'll load the content script into our process scripts and instantiate the class for every relevant window.

comment:4 Changed 4 years ago by trev

  • Blocking 2401 removed
Note: See TracTickets for help on using tickets.