Opened 6 years ago

Closed 6 years ago

Last modified 5 years ago

#24 closed change (fixed)

[libadblockplus integration cleanup] Use Matcher.find() instead of Matcher.matches()

Reported by: fhd Assignee:
Priority: P3 Milestone: Adblock-Plus-for-Android-1.3
Module: Adblock-Plus-for-Android Keywords:
Cc: Blocked By:
Blocking: #7 Platform: Android
Ready: no Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/6298415575072768/

Description

Background

See #7.

What to change

Use Matcher.find() instead of Matcher.matches() (http://codereview.adblockplus.org/11172036/diff/1/src/org/adblockplus/android/AdblockPlus.java#newcode56)

Change History (13)

comment:1 Changed 6 years ago by philll

  • Blocking 7 added

comment:2 Changed 6 years ago by philll

  • Keywords libadblockplus integration cleanup removed

comment:3 Changed 6 years ago by trev

  • Component changed from Unknown to ABP-Android

comment:4 Changed 6 years ago by philll

  • Owner set to rjeschke
  • Status changed from new to assigned

comment:5 Changed 6 years ago by fhd

  • Priority changed from Unknown to P3

comment:6 Changed 6 years ago by fhd

  • Reporter changed from philll to fhd

comment:7 Changed 6 years ago by fhd

  • Owner rjeschke deleted

comment:8 Changed 6 years ago by fhd

  • Status changed from assigned to accepted

comment:9 Changed 6 years ago by philll

  • Status changed from accepted to new

comment:11 Changed 6 years ago by rjeschke

  • Resolution set to fixed
  • Status changed from new to closed

comment:12 Changed 6 years ago by philll

  • Review URL(s) modified (diff)

comment:13 Changed 5 years ago by trev

  • Milestone set to Adblock-Plus-for-Android-1.3
  • Platform set to Android
Note: See TracTickets for help on using tickets.