Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#2401 closed change (fixed)

Integrate CSS property rule handling in Firefox

Reported by: trev Assignee: trev
Priority: P2 Milestone: Adblock-Plus-2.7.3-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By: #2396, #3499, #3813, #3834, #3835, #3837, #3960
Blocking: #2398 Platform: Unknown
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29338602/
https://codereview.adblockplus.org/29338638/

Description

Background

Once all the necessary mechanisms are in place, we still need code to make sure the content script for CSS property rules is applied.

What to change

Update adblockplusui dependency in order to use the latest messageResponder.js version. Add code to listen to new documents being created, inject the content script into any pages having CSS property rules associated with them.

Change History (16)

comment:1 Changed 3 years ago by trev

  • Blocked By 3499 added; 2399 removed
  • Tester set to Unknown

comment:2 Changed 3 years ago by trev

  • Blocked By 2400 removed

comment:3 Changed 3 years ago by trev

  • Blocked By 3813 added

comment:4 Changed 3 years ago by trev

  • Owner set to trev

comment:5 Changed 3 years ago by trev

  • Review URL(s) modified (diff)

Put a tiny change to the content script under review, it won't work correctly in Firefox otherwise. Will create a separate review for the main code shortly.

comment:6 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
https://hg.adblockplus.org/adblockpluscore/rev/9dbbcdc4ff57

comment:7 Changed 3 years ago by trev

  • Blocked By 3834 added

comment:8 Changed 3 years ago by trev

  • Blocked By 3835 added

comment:9 Changed 3 years ago by trev

  • Blocked By 3836 added

comment:10 Changed 3 years ago by trev

  • Blocked By 3836 removed

comment:11 Changed 3 years ago by trev

  • Blocked By 3837 added

comment:12 Changed 3 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:13 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
https://hg.adblockplus.org/adblockplus/rev/a67269ee21f4

comment:14 Changed 3 years ago by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:15 Changed 3 years ago by trev

  • Blocked By 3960 added

comment:16 Changed 3 years ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

CSS property rules are in the build and usable.

ABP 2.7.2.4166
Firefox 38 / 44 / 45 / Windows 8
Firefox 38 / 44 / OSX 10.11
Firefox 44 / Ubuntu 14.04

Note: See TracTickets for help on using tickets.